From 03ed1726230649665bad57530ebdffd2020a71df Mon Sep 17 00:00:00 2001
From: Kunal Karmakar <kkdthunlshd@gmail.com>
Date: Sat, 14 Mar 2026 07:01:05 +0000
Subject: [PATCH] Fix linting checks

---
 pkg/providers/common/common_test.go | 46 ++++++++++++++++++++++-------
 pkg/providers/factory_provider.go   |  6 ++--
 2 files changed, 39 insertions(+), 13 deletions(-)

diff --git a/pkg/providers/common/common_test.go b/pkg/providers/common/common_test.go
index b1ab4c909..bb7e7434d 100644
--- a/pkg/providers/common/common_test.go
+++ b/pkg/providers/common/common_test.go
@@ -262,8 +262,12 @@ func TestHandleErrorResponse_JSONError(t *testing.T) {
 	}))
 	defer server.Close()
 
-	resp, _ := http.Get(server.URL)
-	err := HandleErrorResponse(resp, server.URL)
+	resp, err := http.Get(server.URL)
+	if err != nil {
+		t.Fatalf("http.Get() error = %v", err)
+	}
+	defer resp.Body.Close()
+	err = HandleErrorResponse(resp, server.URL)
 	if err == nil {
 		t.Fatal("expected error")
 	}
@@ -283,8 +287,12 @@ func TestHandleErrorResponse_HTMLError(t *testing.T) {
 	}))
 	defer server.Close()
 
-	resp, _ := http.Get(server.URL)
-	err := HandleErrorResponse(resp, server.URL)
+	resp, err := http.Get(server.URL)
+	if err != nil {
+		t.Fatalf("http.Get() error = %v", err)
+	}
+	defer resp.Body.Close()
+	err = HandleErrorResponse(resp, server.URL)
 	if err == nil {
 		t.Fatal("expected error")
 	}
@@ -302,7 +310,11 @@ func TestReadAndParseResponse_ValidJSON(t *testing.T) {
 	}))
 	defer server.Close()
 
-	resp, _ := http.Get(server.URL)
+	resp, err := http.Get(server.URL)
+	if err != nil {
+		t.Fatalf("http.Get() error = %v", err)
+	}
+	defer resp.Body.Close()
 	out, err := ReadAndParseResponse(resp, server.URL)
 	if err != nil {
 		t.Fatalf("ReadAndParseResponse() error = %v", err)
@@ -319,8 +331,12 @@ func TestReadAndParseResponse_HTMLResponse(t *testing.T) {
 	}))
 	defer server.Close()
 
-	resp, _ := http.Get(server.URL)
-	_, err := ReadAndParseResponse(resp, server.URL)
+	resp, err := http.Get(server.URL)
+	if err != nil {
+		t.Fatalf("http.Get() error = %v", err)
+	}
+	defer resp.Body.Close()
+	_, err = ReadAndParseResponse(resp, server.URL)
 	if err == nil {
 		t.Fatal("expected error for HTML response")
 	}
@@ -484,8 +500,12 @@ func TestHandleErrorResponse_EmptyBody(t *testing.T) {
 	}))
 	defer server.Close()
 
-	resp, _ := http.Get(server.URL)
-	err := HandleErrorResponse(resp, server.URL)
+	resp, err := http.Get(server.URL)
+	if err != nil {
+		t.Fatalf("http.Get() error = %v", err)
+	}
+	defer resp.Body.Close()
+	err = HandleErrorResponse(resp, server.URL)
 	if err == nil {
 		t.Fatal("expected error")
 	}
@@ -503,8 +523,12 @@ func TestReadAndParseResponse_InvalidJSON(t *testing.T) {
 	}))
 	defer server.Close()
 
-	resp, _ := http.Get(server.URL)
-	_, err := ReadAndParseResponse(resp, server.URL)
+	resp, err := http.Get(server.URL)
+	if err != nil {
+		t.Fatalf("http.Get() error = %v", err)
+	}
+	defer resp.Body.Close()
+	_, err = ReadAndParseResponse(resp, server.URL)
 	if err == nil {
 		t.Fatal("expected error for invalid JSON")
 	}
diff --git a/pkg/providers/factory_provider.go b/pkg/providers/factory_provider.go
index 4200e6e7e..b7567f9fc 100644
--- a/pkg/providers/factory_provider.go
+++ b/pkg/providers/factory_provider.go
@@ -10,8 +10,8 @@ import (
 	"strings"
 
 	"github.com/sipeed/picoclaw/pkg/config"
-	"github.com/sipeed/picoclaw/pkg/providers/azure"
 	anthropicmessages "github.com/sipeed/picoclaw/pkg/providers/anthropic_messages"
+	"github.com/sipeed/picoclaw/pkg/providers/azure"
 )
 
 // createClaudeAuthProvider creates a Claude provider using OAuth credentials from auth store.
@@ -102,7 +102,9 @@ func CreateProviderFromConfig(cfg *config.ModelConfig) (LLMProvider, string, err
 			return nil, "", fmt.Errorf("api_key is required for azure protocol")
 		}
 		if cfg.APIBase == "" {
-			return nil, "", fmt.Errorf("api_base is required for azure protocol (e.g., https://your-resource.openai.azure.com)")
+			return nil, "", fmt.Errorf(
+				"api_base is required for azure protocol (e.g., https://your-resource.openai.azure.com)",
+			)
 		}
 		return azure.NewProviderWithTimeout(
 			cfg.APIKey,