From 1434edcb764992c7a1d7877bbc2c97dbcce2516d Mon Sep 17 00:00:00 2001 From: xiaoen <2768753269@qq.com> Date: Sat, 7 Mar 2026 21:16:58 +0800 Subject: [PATCH] fix(session): propagate compact error from Save Save() was swallowing the error returned by Compact and always returning nil. Callers checking Save's return value would never see a compaction failure. Return the error directly so the agent loop can log or handle it as needed. --- pkg/session/jsonl_backend.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/session/jsonl_backend.go b/pkg/session/jsonl_backend.go index 04bbd8dc9..7f470de15 100644 --- a/pkg/session/jsonl_backend.go +++ b/pkg/session/jsonl_backend.go @@ -72,10 +72,7 @@ func (b *JSONLBackend) TruncateHistory(key string, keepLast int) { // immediately, the data is already durable. Save runs compaction to reclaim // space from logically truncated messages (no-op when there are none). func (b *JSONLBackend) Save(key string) error { - if err := b.store.Compact(context.Background(), key); err != nil { - log.Printf("session: compact %s: %v", key, err) - } - return nil + return b.store.Compact(context.Background(), key) } // Close releases resources held by the underlying store.