opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: check json.Decode errors and use errors.New instead of fmt.Errorf

Browse source
This commit is contained in:
perhapzz 2026-03-20 10:48:04 +00:00
parent 0276554d9c
commit 2a28198d0f
1 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
pkg/health/server_test.go
View file

@ -3,7 +3,7 @@ package health
import ( import (
"context" "context"
"encoding/json" "encoding/json"
"fmt" "errors"
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
"testing" "testing"
@ -58,7 +58,9 @@ func TestReadyHandler_NotReady(t *testing.T) {
} }
var resp StatusResponse var resp StatusResponse
json.NewDecoder(w.Body).Decode(&resp) if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp.Status != "not ready" { if resp.Status != "not ready" {
t.Errorf("status = %q, want %q", resp.Status, "not ready") t.Errorf("status = %q, want %q", resp.Status, "not ready")
} }
@ -78,7 +80,9 @@ func TestReadyHandler_Ready(t *testing.T) {
} }
var resp StatusResponse var resp StatusResponse
json.NewDecoder(w.Body).Decode(&resp) if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp.Status != "ready" { if resp.Status != "ready" {
t.Errorf("status = %q, want %q", resp.Status, "ready") t.Errorf("status = %q, want %q", resp.Status, "ready")
} }
@ -103,7 +107,9 @@ func TestReadyHandler_FailedCheck(t *testing.T) {
} }
var resp StatusResponse var resp StatusResponse
json.NewDecoder(w.Body).Decode(&resp) if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp.Status != "not ready" { if resp.Status != "not ready" {
t.Errorf("status = %q, want %q", resp.Status, "not ready") t.Errorf("status = %q, want %q", resp.Status, "not ready")
} }
@ -137,7 +143,9 @@ func TestReadyHandler_PassingCheck(t *testing.T) {
} }
var resp StatusResponse var resp StatusResponse
json.NewDecoder(w.Body).Decode(&resp) if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp.Checks["redis"].Status != "ok" { if resp.Checks["redis"].Status != "ok" {
t.Errorf("redis check status = %q, want %q", resp.Checks["redis"].Status, "ok") t.Errorf("redis check status = %q, want %q", resp.Checks["redis"].Status, "ok")
} }
@ -193,7 +201,7 @@ func TestReloadHandler_Success(t *testing.T) {
func TestReloadHandler_Error(t *testing.T) { func TestReloadHandler_Error(t *testing.T) {
s := newTestServer() s := newTestServer()
s.SetReloadFunc(func() error { s.SetReloadFunc(func() error {
return fmt.Errorf("config parse error") return errors.New("config parse error")
}) })
req := httptest.NewRequest(http.MethodPost, "/reload", nil) req := httptest.NewRequest(http.MethodPost, "/reload", nil)
@ -249,7 +257,9 @@ func TestRegisterCheck_MultipleChecks(t *testing.T) {
} }
var resp StatusResponse var resp StatusResponse
json.NewDecoder(w.Body).Decode(&resp) if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if len(resp.Checks) != 3 { if len(resp.Checks) != 3 {
t.Errorf("checks count = %d, want 3", len(resp.Checks)) t.Errorf("checks count = %d, want 3", len(resp.Checks))
} }