From 3101c33cc7a610f3e6588af9d4d82687bd1beb68 Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Mon, 16 Feb 2026 00:13:20 +0900 Subject: [PATCH] Remove premature defer client.Stop() in GitHub Copilot provider --- pkg/providers/github_copilot_provider.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pkg/providers/github_copilot_provider.go b/pkg/providers/github_copilot_provider.go index 5058819f5..97f610196 100644 --- a/pkg/providers/github_copilot_provider.go +++ b/pkg/providers/github_copilot_provider.go @@ -33,11 +33,15 @@ func NewGitHubCopilotProvider(uri string, connectMode string, model string) (*Gi if err := client.Start(context.Background()); err != nil { return nil, fmt.Errorf("Can't connect to Github Copilot, https://github.com/github/copilot-sdk/blob/main/docs/getting-started.md#connecting-to-an-external-cli-server for details") } - defer client.Stop() - session, _ = client.CreateSession(context.Background(), &copilot.SessionConfig{ + var err error + session, err = client.CreateSession(context.Background(), &copilot.SessionConfig{ Model: model, Hooks: &copilot.SessionHooks{}, }) + if err != nil { + client.Stop() + return nil, fmt.Errorf("failed to create Copilot session: %w", err) + } }