From 31906c8f19a226862a70e528ac74cf56fcfbb5ea Mon Sep 17 00:00:00 2001 From: stevef Date: Sun, 19 Apr 2026 11:02:51 +0200 Subject: [PATCH] Revert "feat(agent): support global memory inheritance in isolated agents" This reverts commit 8106d61011e00ad21f65d9e37faaa931389f2654. --- pkg/agent/context.go | 2 +- pkg/agent/memory.go | 38 +++++++++----------------------------- 2 files changed, 10 insertions(+), 30 deletions(-) diff --git a/pkg/agent/context.go b/pkg/agent/context.go index f7b48850c..7f1cac4b1 100644 --- a/pkg/agent/context.go +++ b/pkg/agent/context.go @@ -86,7 +86,7 @@ func NewContextBuilder(workspace string, baseWorkspace string) *ContextBuilder { workspace: workspace, baseWorkspace: baseWorkspace, skillsLoader: skills.NewSkillsLoader(workspace, baseWorkspace, globalSkillsDir, builtinSkillsDir, nil, false), - memory: NewMemoryStore(workspace, baseWorkspace), + memory: NewMemoryStore(workspace), } } diff --git a/pkg/agent/memory.go b/pkg/agent/memory.go index 5765a74bf..01e682f3b 100644 --- a/pkg/agent/memory.go +++ b/pkg/agent/memory.go @@ -20,16 +20,14 @@ import ( // - Long-term memory: memory/MEMORY.md // - Daily notes: memory/YYYYMM/YYYYMMDD.md type MemoryStore struct { - workspace string - baseWorkspace string - memoryDir string - memoryFile string + workspace string + memoryDir string + memoryFile string } // NewMemoryStore creates a new MemoryStore with the given workspace path. -// It also takes an optional baseWorkspace for global memory inheritance. // It ensures the memory directory exists. -func NewMemoryStore(workspace string, baseWorkspace string) *MemoryStore { +func NewMemoryStore(workspace string) *MemoryStore { memoryDir := filepath.Join(workspace, "memory") memoryFile := filepath.Join(memoryDir, "MEMORY.md") @@ -37,10 +35,9 @@ func NewMemoryStore(workspace string, baseWorkspace string) *MemoryStore { os.MkdirAll(memoryDir, 0o755) return &MemoryStore{ - workspace: workspace, - baseWorkspace: baseWorkspace, - memoryDir: memoryDir, - memoryFile: memoryFile, + workspace: workspace, + memoryDir: memoryDir, + memoryFile: memoryFile, } } @@ -134,35 +131,18 @@ func (ms *MemoryStore) GetRecentDailyNotes(days int) string { // GetMemoryContext returns formatted memory context for the agent prompt. // Includes long-term memory and recent daily notes. -// If baseWorkspace is set, it also includes global memory context. func (ms *MemoryStore) GetMemoryContext() string { longTerm := ms.ReadLongTerm() recentNotes := ms.GetRecentDailyNotes(3) - var globalLongTerm string - if ms.baseWorkspace != "" && ms.baseWorkspace != ms.workspace { - globalFile := filepath.Join(ms.baseWorkspace, "memory", "MEMORY.md") - if data, err := os.ReadFile(globalFile); err == nil { - globalLongTerm = string(data) - } - } - - if longTerm == "" && recentNotes == "" && globalLongTerm == "" { + if longTerm == "" && recentNotes == "" { return "" } var sb strings.Builder - if globalLongTerm != "" { - sb.WriteString("## Global Memory\n\n") - sb.WriteString(globalLongTerm) - if longTerm != "" || recentNotes != "" { - sb.WriteString("\n\n---\n\n") - } - } - if longTerm != "" { - sb.WriteString("## Session Memory\n\n") + sb.WriteString("## Long-term Memory\n\n") sb.WriteString(longTerm) }