opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix github registry URL scheme validation

Browse source
This commit is contained in:
lxowalle 2026-04-12 22:51:42 +08:00
parent ef6fbef559
commit 383b13b11e
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/skills/installer.go
View file

@ -187,6 +187,9 @@ func matchesGitHubWebBase(repoURL *url.URL, webBaseURL string) bool {
if err != nil {
return false
}
if !strings.EqualFold(repoURL.Scheme, baseURL.Scheme) {
return false
}
if !strings.EqualFold(repoURL.Host, baseURL.Host) {
return false
}

12
pkg/skills/installer_test.go
View file

@ -200,6 +200,18 @@ func TestParseGitHubRefWithBaseURL(t *testing.T) {
if !strings.Contains(err.Error(), `invalid GitHub URL host "gitlab.example.com"`) {
t.Fatalf("unexpected error = %v", err)
}
_, err = parseGitHubRefWithBaseURL(
"http://ghe.example.com/git/org/repo/tree/dev/skills/test",
"https://ghe.example.com/git",
"main",
)
if err == nil {
t.Fatal("parseGitHubRefWithBaseURL() error = nil, want invalid host error for scheme mismatch")
}
if !strings.Contains(err.Error(), `invalid GitHub URL host "ghe.example.com"`) {
t.Fatalf("unexpected scheme mismatch error = %v", err)
}
}
func TestSkillInstallerResolveGitHubRefUsesDefaultBranch(t *testing.T) {