opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(cron): keep deliver=false job responses silent

Browse source
This commit is contained in:
Alix-007 2026-03-29 15:35:46 +08:00
parent e70928cc6f
commit 4736b03c2c
2 changed files with 30 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/tools/cron.go
View file

@ -411,7 +411,8 @@ func (t *CronTool) ExecuteJob(ctx context.Context, job *cron.CronJob) string {
return fmt.Sprintf("Error: %v", err) return fmt.Sprintf("Error: %v", err)
} }
if response != "" { // deliver=false should execute silently: no outbound publish path.
if job.Payload.Deliver && response != "" {
t.executor.PublishResponseIfNeeded(ctx, channel, chatID, response) t.executor.PublishResponseIfNeeded(ctx, channel, chatID, response)
} }
return "ok" return "ok"

36
pkg/tools/cron_test.go
View file

@ -280,7 +280,7 @@ func TestCronTool_ExecuteJobPublishesErrorWhenExecDisabled(t *testing.T) {
} }
} }
func TestCronTool_ExecuteJobPublishesAgentResponse(t *testing.T) { func TestCronTool_ExecuteJobDeliverFalseRunsAgentSilently(t *testing.T) {
executor := &stubJobExecutor{response: "generated reply"} executor := &stubJobExecutor{response: "generated reply"}
tool := newTestCronToolWithExecutorAndConfig(t, executor, config.DefaultConfig()) tool := newTestCronToolWithExecutorAndConfig(t, executor, config.DefaultConfig())
@ -302,11 +302,8 @@ func TestCronTool_ExecuteJobPublishesAgentResponse(t *testing.T) {
if executor.lastPrompt != "send me a poem" { if executor.lastPrompt != "send me a poem" {
t.Fatalf("prompt = %q, want original message", executor.lastPrompt) t.Fatalf("prompt = %q, want original message", executor.lastPrompt)
} }
if executor.publishedResp != "generated reply" { if executor.publishedResp != "" {
t.Fatalf("published response = %q, want generated reply", executor.publishedResp) t.Fatalf("expected no published response for deliver=false, got %q", executor.publishedResp)
}
if executor.publishedChan != "telegram" || executor.publishedChatID != "chat-1" {
t.Fatalf("published target = %s/%s, want telegram/chat-1", executor.publishedChan, executor.publishedChatID)
} }
} }
@ -365,8 +362,8 @@ func TestCronTool_ExecuteJobDirectiveAddsPromptPrefix(t *testing.T) {
if executor.lastPrompt != wantPrompt { if executor.lastPrompt != wantPrompt {
t.Fatalf("prompt = %q, want exact %q", executor.lastPrompt, wantPrompt) t.Fatalf("prompt = %q, want exact %q", executor.lastPrompt, wantPrompt)
} }
if executor.publishedResp != "directive result" { if executor.publishedResp != "" {
t.Fatalf("published response = %q, want %q", executor.publishedResp, "directive result") t.Fatalf("expected no published response for deliver=false directive job, got %q", executor.publishedResp)
} }
} }
@ -403,6 +400,29 @@ func TestCronTool_ExecuteJobDirectiveWithDeliverRoutesToAgent(t *testing.T) {
} }
} }
func TestCronTool_ExecuteJobDirectiveWithDeliverFalseStaysSilent(t *testing.T) {
executor := &stubJobExecutor{response: "agent processed"}
tool := newTestCronToolWithExecutorAndConfig(t, executor, config.DefaultConfig())
job := &cron.CronJob{ID: "job-dir-silent"}
job.Payload.Channel = "telegram"
job.Payload.To = "chat-1"
job.Payload.Message = "generate daily report"
job.Payload.Type = "directive"
job.Payload.Deliver = false
if got := tool.ExecuteJob(context.Background(), job); got != "ok" {
t.Fatalf("ExecuteJob() = %q, want ok", got)
}
if executor.lastPrompt == "" {
t.Fatal("expected agent to be called for directive+deliver=false, but ProcessDirectWithChannel was not invoked")
}
if executor.publishedResp != "" {
t.Fatalf("expected no published response for deliver=false directive job, got %q", executor.publishedResp)
}
}
func TestCronTool_ExecuteJobDeliverMessageDirectlyToBus(t *testing.T) { func TestCronTool_ExecuteJobDeliverMessageDirectlyToBus(t *testing.T) {
executor := &stubJobExecutor{response: "should not be called"} executor := &stubJobExecutor{response: "should not be called"}
tool := newTestCronToolWithExecutorAndConfig(t, executor, config.DefaultConfig()) tool := newTestCronToolWithExecutorAndConfig(t, executor, config.DefaultConfig())