opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: address review feedback - proper provider check and proxy support

Browse source
This commit is contained in:
Ashish Sharma 2026-02-20 19:14:24 +05:30
parent 032f107935
commit 597115817d
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/providers/http_provider.go
View file

@ -178,6 +178,11 @@ func (p *HTTPProvider) parseResponse(body []byte) (*LLMResponse, error) {
} }
} }
// Fix: skip tool calls with empty names to avoid downstream errors
if name == "" {
continue
}
toolCalls = append(toolCalls, ToolCall{ toolCalls = append(toolCalls, ToolCall{
ID: tc.ID, ID: tc.ID,
Name: name, Name: name,
@ -285,7 +290,8 @@ func CreateProvider(cfg *config.Config) (LLMProvider, error) {
apiKey = cfg.Providers.Gemini.APIKey apiKey = cfg.Providers.Gemini.APIKey
apiBase = cfg.Providers.Gemini.APIBase apiBase = cfg.Providers.Gemini.APIBase
if apiBase == "" { if apiBase == "" {
apiBase = "https://generativelanguage.googleapis.com/v1beta" // Use OpenAI-compatible endpoint for tool calling support
apiBase = "https://generativelanguage.googleapis.com/v1beta/openai"
} }
} }
case "vllm": case "vllm":
@ -388,7 +394,8 @@ func CreateProvider(cfg *config.Config) (LLMProvider, error) {
apiBase = cfg.Providers.Gemini.APIBase apiBase = cfg.Providers.Gemini.APIBase
proxy = cfg.Providers.Gemini.Proxy proxy = cfg.Providers.Gemini.Proxy
if apiBase == "" { if apiBase == "" {
apiBase = "https://generativelanguage.googleapis.com/v1beta" // Use OpenAI-compatible endpoint for tool calling support
apiBase = "https://generativelanguage.googleapis.com/v1beta/openai"
} }
case (strings.Contains(lowerModel, "glm") || strings.Contains(lowerModel, "zhipu") || strings.Contains(lowerModel, "zai")) && cfg.Providers.Zhipu.APIKey != "": case (strings.Contains(lowerModel, "glm") || strings.Contains(lowerModel, "zhipu") || strings.Contains(lowerModel, "zai")) && cfg.Providers.Zhipu.APIKey != "":
@ -452,4 +459,4 @@ func CreateProvider(cfg *config.Config) (LLMProvider, error) {
} }
return NewHTTPProvider(apiKey, apiBase, proxy), nil return NewHTTPProvider(apiKey, apiBase, proxy), nil
} }