From 7d44ce72cfc99bcc87af95c8a2a46934cb997961 Mon Sep 17 00:00:00 2001 From: SakoroYou <165740095+Sakurapainting@users.noreply.github.com> Date: Fri, 27 Mar 2026 19:02:09 +0800 Subject: [PATCH] fix: avoid leak details contained in the error string This fmt.Printf adds an extra stdout error line on send failures. Besides duplicating the logger entry above, it can leak details contained in the error string (potentially including QQ identifiers) and makes it harder to control output in embedded deployments. Consider removing this print and relying on logger.ErrorCF (or gating any user-facing output behind a CLI-specific layer). Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- pkg/channels/qq/qq.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/channels/qq/qq.go b/pkg/channels/qq/qq.go index f7fd0c3b4..4a8ea1f5a 100644 --- a/pkg/channels/qq/qq.go +++ b/pkg/channels/qq/qq.go @@ -353,7 +353,6 @@ func (c *QQChannel) Send(ctx context.Context, msg bus.OutboundMessage) error { "chat_kind": chatKind, "error": err.Error(), }) - fmt.Printf("QQ send failed: %v\n", err) return fmt.Errorf("qq send: %w", channels.ErrTemporary) }