From 9929003f69e12e1573c6debce48acf663733de47 Mon Sep 17 00:00:00 2001 From: Ruslan Semagin Date: Thu, 19 Feb 2026 16:18:25 +0300 Subject: [PATCH] fix(tests): correct errors.Is argument order and revert unrelated rename - Fix reversed arguments in errors.Is calls in tests - Revert cp -> copy rename in codex_provider.go to keep PR focused --- pkg/providers/codex_provider.go | 4 ++-- pkg/providers/error_classifier_test.go | 2 +- pkg/tools/message_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/providers/codex_provider.go b/pkg/providers/codex_provider.go index a743d8c69..e3526cfb5 100644 --- a/pkg/providers/codex_provider.go +++ b/pkg/providers/codex_provider.go @@ -91,8 +91,8 @@ func (p *CodexProvider) Chat(ctx context.Context, messages []Message, tools []To if evt.Type == "response.completed" || evt.Type == "response.failed" || evt.Type == "response.incomplete" { evtResp := evt.Response if evtResp.ID != "" { - cp := evtResp - resp = &cp + copy := evtResp + resp = © } } } diff --git a/pkg/providers/error_classifier_test.go b/pkg/providers/error_classifier_test.go index d55585f55..34dc3ea3f 100644 --- a/pkg/providers/error_classifier_test.go +++ b/pkg/providers/error_classifier_test.go @@ -293,7 +293,7 @@ func TestFailoverError_ErrorString(t *testing.T) { func TestFailoverError_Unwrap(t *testing.T) { inner := errors.New("inner error") fe := &FailoverError{Reason: FailoverTimeout, Wrapped: inner} - if !errors.Is(inner, fe.Unwrap()) { + if !errors.Is(fe.Unwrap(), inner) { t.Error("Unwrap should return wrapped error") } } diff --git a/pkg/tools/message_test.go b/pkg/tools/message_test.go index 468f4aada..e11c0684d 100644 --- a/pkg/tools/message_test.go +++ b/pkg/tools/message_test.go @@ -126,7 +126,7 @@ func TestMessageTool_Execute_SendFailure(t *testing.T) { if result.Err == nil { t.Error("Expected Err to be set") } - if !errors.Is(sendErr, result.Err) { + if !errors.Is(result.Err, sendErr) { t.Errorf("Expected Err to be sendErr, got %v", result.Err) } }