opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: potential handle leak when send attachments on slack

Browse source
This commit is contained in:
XZB-1248 2026-02-19 22:07:18 +08:00
parent 45d2edef5c
commit a31403c547
1 changed files with 20 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
pkg/channels/slack.go
View file

@ -155,24 +155,28 @@ func (c *SlackChannel) Send(ctx context.Context, msg bus.OutboundMessage) error
func (c *SlackChannel) sendWithAttachments(ctx context.Context, channelID, threadTS, content string, attachments []bus.Attachment) error {
for _, attachment := range attachments {
file, err := os.Open(attachment.Path)
if err != nil {
return fmt.Errorf("failed to open attachment %s: %w", attachment.Path, err)
}
uploadErr := func() error {
file, err := os.Open(attachment.Path)
if err != nil {
return fmt.Errorf("failed to open attachment %s: %w", attachment.Path, err)
}
defer file.Close()
params := slack.UploadFileV2Parameters{
Channel: channelID,
Filename: attachment.Filename,
Reader: file,
InitialComment: content,
ThreadTimestamp: threadTS,
}
params := slack.UploadFileV2Parameters{
Channel: channelID,
Filename: attachment.Filename,
Reader: file,
InitialComment: content,
ThreadTimestamp: threadTS,
}
_, err = c.api.UploadFileV2Context(ctx, params)
defer file.Close()
if err != nil {
return fmt.Errorf("failed to upload file %s: %w", attachment.Filename, err)
if _, err = c.api.UploadFileV2Context(ctx, params); err != nil {
return fmt.Errorf("failed to upload file %s: %w", attachment.Filename, err)
}
return nil
}()
if uploadErr != nil {
return uploadErr
}
// Only use content for first attachment to avoid duplicate comments