From b44b0a0b579e00eecb23cb8a518538b12e086296 Mon Sep 17 00:00:00 2001 From: Boris Bliznioukov Date: Fri, 6 Mar 2026 16:13:04 +0100 Subject: [PATCH] refactor(docs): simplify magic constants section in DDR session summarization design Signed-off-by: Boris Bliznioukov --- docs/design/DDR-session-summarization.md | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/docs/design/DDR-session-summarization.md b/docs/design/DDR-session-summarization.md index 621f01eca..169d7b809 100644 --- a/docs/design/DDR-session-summarization.md +++ b/docs/design/DDR-session-summarization.md @@ -39,20 +39,7 @@ Session context grows without bound during long conversations. The original impl - `WithLLMSummarizer(provider, model, agentID string, cfg config.SummarizationConfig) Option` — convenience, constructs `LLMSummarizer` internally. - When `summarizer` is nil, `MaybeSummarize` is a no-op. -4. **MUST** replace all magic constants with named defaults in `pkg/config`: - | Constant | Value | Field | - |---|---|---| - | `DefaultSummarizeMessageThreshold` | `20` | `MessageThreshold` | - | `DefaultSummarizeTokenPercent` | `75` | `TokenPercent` | - | `DefaultKeepLastMessages` | `4` | `KeepLastMessages` | - | `DefaultContextWindow` | `8192` | `ContextWindow` | - | `DefaultSummaryMaxTokens` | `1024` | `SummaryMaxTokens` | - | `DefaultSummarizationTemperature` | `0.3` | `SummaryTemperature` | - | `DefaultMultiPartBatchThreshold` | `10` | `MultiPartBatchThreshold` | - | `DefaultSummarizationTimeout` | `120s` | `Timeout` | - | `DefaultMaxSingleMsgTokenRatio` | `0.5` | `MaxSingleMsgTokenRatio` | - | `DefaultForceCompressionMinMsgs` | `4` | `ForceCompressionMinMessages` | - | `DefaultCharsPerToken` | `2.5` | `CharsPerToken` | +4. **MUST** replace all magic constants with named defaults in `pkg/config` 5. **MUST** use a single `SummarizationConfig` struct in `pkg/config` as the sole config type for both user-facing JSON fields and internal tuning parameters: