opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: panic in atomic save when sanitizeHistory shrinks history

Browse source 
historyOffset was computed from len(history) before sanitization,
but BuildMessages runs sanitizeHistory which can remove messages.
This caused a slice bounds out of range panic when the sanitized
history was shorter than the original.

Fix: compute offset from actual messages slice length instead.
This commit is contained in:
pkonowrocki 2026-02-15 17:19:56 +01:00
parent 15ed22a3cd
commit bbb4266060
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/agent/loop.go
View file

@ -374,7 +374,9 @@ func (al *AgentLoop) runAgentLoop(ctx context.Context, opts processOptions) (str
) )
// 3. Run LLM iteration loop (no session saves until success) // 3. Run LLM iteration loop (no session saves until success)
historyOffset := 1 + len(history) // skip system prompt + existing history // Offset points to the user message (last element BuildMessages added).
// We save from here onward after success (user + any tool-call messages).
historyOffset := len(messages) - 1
finalContent, messages, iteration, err := al.runLLMIteration(ctx, messages, opts) finalContent, messages, iteration, err := al.runLLMIteration(ctx, messages, opts)
if err != nil { if err != nil {
return "", err return "", err