From c45811f2d97642c1abbb470cb0558a544e29dfe2 Mon Sep 17 00:00:00 2001
From: Ruslan Semagin <pixel.365.24@gmail.com>
Date: Tue, 24 Feb 2026 09:22:46 +0300
Subject: [PATCH] test: simplify allowed command checks using slices.Contains

---
 cmd/picoclaw/internal/auth/command_test.go | 13 ++++++------
 cmd/picoclaw/internal/cron/command_test.go | 15 +++++++-------
 cmd/picoclaw/main_test.go                  | 23 +++++++++++-----------
 3 files changed, 27 insertions(+), 24 deletions(-)

diff --git a/cmd/picoclaw/internal/auth/command_test.go b/cmd/picoclaw/internal/auth/command_test.go
index 8696cdc0a..48dc704dd 100644
--- a/cmd/picoclaw/internal/auth/command_test.go
+++ b/cmd/picoclaw/internal/auth/command_test.go
@@ -1,6 +1,7 @@
 package auth
 
 import (
+	"slices"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -26,18 +27,18 @@ func TestNewAuthCommand(t *testing.T) {
 	assert.False(t, cmd.HasFlags())
 	assert.True(t, cmd.HasSubCommands())
 
-	allowedCommands := map[string]struct{}{
-		"login":  {},
-		"logout": {},
-		"status": {},
-		"models": {},
+	allowedCommands := []string{
+		"login",
+		"logout",
+		"status",
+		"models",
 	}
 
 	subcommands := cmd.Commands()
 	assert.Len(t, subcommands, len(allowedCommands))
 
 	for _, subcmd := range subcommands {
-		_, found := allowedCommands[subcmd.Name()]
+		found := slices.Contains(allowedCommands, subcmd.Name())
 		assert.True(t, found, "unexpected subcommand %q", subcmd.Name())
 
 		assert.Len(t, subcmd.Aliases, 0)
diff --git a/cmd/picoclaw/internal/cron/command_test.go b/cmd/picoclaw/internal/cron/command_test.go
index cbcdec833..af2ac83ae 100644
--- a/cmd/picoclaw/internal/cron/command_test.go
+++ b/cmd/picoclaw/internal/cron/command_test.go
@@ -1,6 +1,7 @@
 package cron
 
 import (
+	"slices"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -28,19 +29,19 @@ func TestNewCronCommand(t *testing.T) {
 
 	assert.True(t, cmd.HasSubCommands())
 
-	allowedCommands := map[string]struct{}{
-		"list":    {},
-		"add":     {},
-		"remove":  {},
-		"enable":  {},
-		"disable": {},
+	allowedCommands := []string{
+		"list",
+		"add",
+		"remove",
+		"enable",
+		"disable",
 	}
 
 	subcommands := cmd.Commands()
 	assert.Len(t, subcommands, len(allowedCommands))
 
 	for _, subcmd := range subcommands {
-		_, found := allowedCommands[subcmd.Name()]
+		found := slices.Contains(allowedCommands, subcmd.Name())
 		assert.True(t, found, "unexpected subcommand %q", subcmd.Name())
 
 		assert.Len(t, subcmd.Aliases, 0)
diff --git a/cmd/picoclaw/main_test.go b/cmd/picoclaw/main_test.go
index 3aa35b20b..875ad8009 100644
--- a/cmd/picoclaw/main_test.go
+++ b/cmd/picoclaw/main_test.go
@@ -1,6 +1,7 @@
 package main
 
 import (
+	"slices"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -26,23 +27,23 @@ func TestNewPicoclawCommand(t *testing.T) {
 	assert.Nil(t, cmd.PersistentPreRun)
 	assert.Nil(t, cmd.PersistentPostRun)
 
-	allowedCommands := map[string]struct{}{
-		"agent":   {},
-		"auth":    {},
-		"cron":    {},
-		"gateway": {},
-		"migrate": {},
-		"onboard": {},
-		"skills":  {},
-		"status":  {},
-		"version": {},
+	allowedCommands := []string{
+		"agent",
+		"auth",
+		"cron",
+		"gateway",
+		"migrate",
+		"onboard",
+		"skills",
+		"status",
+		"version",
 	}
 
 	subcommands := cmd.Commands()
 	assert.Len(t, subcommands, len(allowedCommands))
 
 	for _, subcmd := range subcommands {
-		_, found := allowedCommands[subcmd.Name()]
+		found := slices.Contains(allowedCommands, subcmd.Name())
 		assert.True(t, found, "unexpected subcommand %q", subcmd.Name())
 
 		assert.False(t, subcmd.Hidden)