From cf3ab0e0e81d6759cc76bb9732f682b7decb2ee6 Mon Sep 17 00:00:00 2001
From: sheeki003 <36009418+sheeki03@users.noreply.github.com>
Date: Mon, 23 Mar 2026 21:41:44 +0530
Subject: [PATCH] test: add tirith guard and installer unit tests

---
 pkg/tools/shell_test.go | 87 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 87 insertions(+)

diff --git a/pkg/tools/shell_test.go b/pkg/tools/shell_test.go
index f8f83ea74..d83898264 100644
--- a/pkg/tools/shell_test.go
+++ b/pkg/tools/shell_test.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 	"time"
@@ -683,3 +684,89 @@ func TestShellTool_URLBypassPrevented(t *testing.T) {
 		}
 	}
 }
+
+// ---------------------------------------------------------------------------
+// Tirith guard tests
+// ---------------------------------------------------------------------------
+
+func TestTirithGuard_Disabled(t *testing.T) {
+	cfg := TirithConfig{Enabled: false}
+	result := tirithGuard("echo hello", cfg)
+	if result != "" {
+		t.Errorf("disabled tirith should allow all commands, got: %s", result)
+	}
+}
+
+func TestTirithGuard_MissingBinary_FailOpen(t *testing.T) {
+	cfg := TirithConfig{
+		Enabled:  true,
+		BinPath:  "/nonexistent/tirith-test-binary",
+		Timeout:  1,
+		FailOpen: true,
+	}
+	tirithMu.Lock()
+	tirithResolvedPath = ""
+	tirithInstallFailed = false
+	tirithMu.Unlock()
+
+	result := tirithGuard("echo hello", cfg)
+	if result != "" {
+		t.Errorf("missing tirith with fail-open should allow, got: %s", result)
+	}
+}
+
+func TestTirithGuard_MissingBinary_FailClosed(t *testing.T) {
+	cfg := TirithConfig{
+		Enabled:  true,
+		BinPath:  "/nonexistent/tirith-test-binary",
+		Timeout:  1,
+		FailOpen: false,
+	}
+	tirithMu.Lock()
+	tirithResolvedPath = ""
+	tirithInstallFailed = false
+	tirithMu.Unlock()
+
+	result := tirithGuard("echo hello", cfg)
+	if result == "" {
+		t.Error("missing tirith with fail-closed should block")
+	}
+	if !strings.Contains(result, "fail-closed") {
+		t.Errorf("expected fail-closed message, got: %s", result)
+	}
+}
+
+func TestTirithSummarize_ValidJSON(t *testing.T) {
+	input := []byte(`{"findings":[{"severity":"HIGH","title":"Pipe to shell"}]}`)
+	result := tirithSummarize(input)
+	if !strings.Contains(result, "Pipe to shell") || !strings.Contains(result, "HIGH") {
+		t.Errorf("expected finding summary, got: %s", result)
+	}
+}
+
+func TestTirithSummarize_InvalidJSON(t *testing.T) {
+	result := tirithSummarize([]byte("not json"))
+	if !strings.Contains(result, "details unavailable") {
+		t.Errorf("expected details unavailable, got: %s", result)
+	}
+}
+
+func TestTirithSummarize_EmptyFindings(t *testing.T) {
+	result := tirithSummarize([]byte(`{"findings":[]}`))
+	if result != "security issue detected" {
+		t.Errorf("expected generic message, got: %s", result)
+	}
+}
+
+func TestTirithDetectTarget(t *testing.T) {
+	target, ext := tirithDetectTarget()
+	if target == "" {
+		t.Skip("unsupported platform for this test")
+	}
+	if runtime.GOOS == "windows" && ext != ".zip" {
+		t.Errorf("windows should use .zip, got: %s", ext)
+	}
+	if runtime.GOOS != "windows" && ext != ".tar.gz" {
+		t.Errorf("unix should use .tar.gz, got: %s", ext)
+	}
+}