opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: deduplicate getDefaultAPIBase and add empty apiBase validation

Browse source 
Export GetDefaultAPIBase from pkg/providers and reuse it in STT
resolution instead of the duplicated getDefaultSTTBase. Skip model
configs with unknown protocols that resolve to an empty API base.

Resolves Copilot review comments on PR #635.
This commit is contained in:
rfshubert 2026-02-22 10:43:37 -03:00
parent 05219a38e3
commit d01a874c17
4 changed files with 30 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
cmd/picoclaw/cmd_gateway.go
View file

@ -241,14 +241,3 @@ func setupCronTool(
return cronService
}
func getDefaultSTTBase(protocol string) string {
switch protocol {
case "openai":
return "https://api.openai.com/v1"
case "groq":
return "https://api.groq.com/openai/v1"
default:
return ""
}
}

5
cmd/picoclaw/stt_resolution.go
View file

@ -20,7 +20,10 @@ func resolveSTTTranscriber(cfg *config.Config) voice.Transcriber {
protocol, modelID := providers.ExtractProtocol(mc.Model)
apiBase := mc.APIBase
if apiBase == "" {
apiBase = getDefaultSTTBase(protocol)
apiBase = providers.GetDefaultAPIBase(protocol)
}
if apiBase == "" {
continue // unknown protocol, skip this entry
}
return voice.NewOpenAICompatTranscriber(mc.APIKey, apiBase, modelID)
}

36
cmd/picoclaw/stt_resolution_test.go
View file

@ -7,22 +7,28 @@ import (
"github.com/sipeed/picoclaw/pkg/voice"
)
func TestGetDefaultSTTBase(t *testing.T) {
tests := []struct {
protocol string
expected string
}{
{"openai", "https://api.openai.com/v1"},
{"groq", "https://api.groq.com/openai/v1"},
{"unknown", ""},
{"", ""},
func TestResolveSTTTranscriber_UnknownProtocolSkipped(t *testing.T) {
// stt_model points to an entry with an unknown protocol and no api_base.
// The unknown protocol resolves to an empty API base, so this entry must be
// skipped (continue) and the function should fall through to return nil.
cfg := &config.Config{
Agents: config.AgentsConfig{
Defaults: config.AgentDefaults{
STTModel: "whisper",
},
},
ModelList: []config.ModelConfig{
{
ModelName: "whisper",
Model: "unknownprotocol/whisper-1",
APIKey: "sk-test",
},
},
}
for _, tt := range tests {
t.Run(tt.protocol, func(t *testing.T) {
if got := getDefaultSTTBase(tt.protocol); got != tt.expected {
t.Errorf("getDefaultSTTBase(%q) = %q, want %q", tt.protocol, got, tt.expected)
}
})
tr := resolveSTTTranscriber(cfg)
if tr != nil {
t.Error("expected nil - unknown protocol with no api_base should be skipped")
}
}

9
pkg/providers/factory_provider.go
View file

@ -82,7 +82,7 @@ func CreateProviderFromConfig(cfg *config.ModelConfig) (LLMProvider, string, err
}
apiBase := cfg.APIBase
if apiBase == "" {
apiBase = getDefaultAPIBase(protocol)
apiBase = GetDefaultAPIBase(protocol)
}
return NewHTTPProviderWithMaxTokensField(cfg.APIKey, apiBase, cfg.Proxy, cfg.MaxTokensField), modelID, nil
@ -95,7 +95,7 @@ func CreateProviderFromConfig(cfg *config.ModelConfig) (LLMProvider, string, err
}
apiBase := cfg.APIBase
if apiBase == "" {
apiBase = getDefaultAPIBase(protocol)
apiBase = GetDefaultAPIBase(protocol)
}
return NewHTTPProviderWithMaxTokensField(cfg.APIKey, apiBase, cfg.Proxy, cfg.MaxTokensField), modelID, nil
@ -155,8 +155,9 @@ func CreateProviderFromConfig(cfg *config.ModelConfig) (LLMProvider, string, err
}
}
// getDefaultAPIBase returns the default API base URL for a given protocol.
func getDefaultAPIBase(protocol string) string {
// GetDefaultAPIBase returns the default API base URL for a given protocol.
// Returns an empty string if the protocol is unknown.
func GetDefaultAPIBase(protocol string) string {
switch protocol {
case "openai":
return "https://api.openai.com/v1"