opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(agent): make exec tool init failure non-fatal

Browse source
This commit is contained in:
Sakurapainting 2026-03-19 19:34:20 +08:00
parent 7673b626b3
commit d7a378cb28
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
pkg/agent/instance.go
View file

@ -3,13 +3,13 @@ package agent
import ( import (
"context" "context"
"fmt" "fmt"
"log"
"os" "os"
"path/filepath" "path/filepath"
"regexp" "regexp"
"strings" "strings"
"github.com/sipeed/picoclaw/pkg/config" "github.com/sipeed/picoclaw/pkg/config"
"github.com/sipeed/picoclaw/pkg/logger"
"github.com/sipeed/picoclaw/pkg/media" "github.com/sipeed/picoclaw/pkg/media"
"github.com/sipeed/picoclaw/pkg/memory" "github.com/sipeed/picoclaw/pkg/memory"
"github.com/sipeed/picoclaw/pkg/providers" "github.com/sipeed/picoclaw/pkg/providers"
@ -85,9 +85,11 @@ func NewAgentInstance(
if cfg.Tools.IsToolEnabled("exec") { if cfg.Tools.IsToolEnabled("exec") {
execTool, err := tools.NewExecToolWithConfig(workspace, restrict, cfg, allowReadPaths) execTool, err := tools.NewExecToolWithConfig(workspace, restrict, cfg, allowReadPaths)
if err != nil { if err != nil {
log.Fatalf("Critical error: unable to initialize exec tool: %v", err) logger.ErrorCF("agent", "Failed to initialize exec tool; continuing without exec",
map[string]any{"error": err.Error()})
} else {
toolsRegistry.Register(execTool)
} }
toolsRegistry.Register(execTool)
} }
if cfg.Tools.IsToolEnabled("edit_file") { if cfg.Tools.IsToolEnabled("edit_file") {
@ -210,8 +212,8 @@ func NewAgentInstance(
}) })
lightCandidates = resolved lightCandidates = resolved
} else { } else {
log.Printf("routing: light_model %q not found in model_list — routing disabled for agent %q", logger.WarnCF("agent", "Routing light model not found; routing disabled",
rc.LightModel, agentID) map[string]any{"light_model": rc.LightModel, "agent_id": agentID})
} }
} }
@ -320,7 +322,8 @@ func (a *AgentInstance) Close() error {
func initSessionStore(dir string) session.SessionStore { func initSessionStore(dir string) session.SessionStore {
store, err := memory.NewJSONLStore(dir) store, err := memory.NewJSONLStore(dir)
if err != nil { if err != nil {
log.Printf("memory: init store: %v; using json sessions", err) logger.WarnCF("agent", "Memory JSONL store init failed; falling back to json sessions",
map[string]any{"error": err.Error()})
return session.NewSessionManager(dir) return session.NewSessionManager(dir)
} }
@ -328,11 +331,12 @@ func initSessionStore(dir string) session.SessionStore {
// Migration failure means the store could not write data. // Migration failure means the store could not write data.
// Fall back to SessionManager to avoid a split state where // Fall back to SessionManager to avoid a split state where
// some sessions are in JSONL and others remain in JSON. // some sessions are in JSONL and others remain in JSON.
log.Printf("memory: migration failed: %v; falling back to json sessions", merr) logger.WarnCF("agent", "Memory migration failed; falling back to json sessions",
map[string]any{"error": merr.Error()})
store.Close() store.Close()
return session.NewSessionManager(dir) return session.NewSessionManager(dir)
} else if n > 0 { } else if n > 0 {
log.Printf("memory: migrated %d session(s) to jsonl", n) logger.InfoCF("agent", "Memory migrated to JSONL", map[string]any{"sessions_migrated": n})
} }
return session.NewJSONLBackend(store) return session.NewJSONLBackend(store)