feat: make summarization message threshold and token percent configurable (#854) (#1029)

Co-authored-by: Rahul Bansal <rahul@hudle.in>

pkg/agent/instance.go

@@ -18,22 +18,24 @@ import (
 // AgentInstance represents a fully configured agent with its own workspace,
 // session manager, context builder, and tool registry.
 type AgentInstance struct {
-	ID             string
+	ID                        string
-	Name           string
+	Name                      string
-	Model          string
+	Model                     string
-	Fallbacks      []string
+	Fallbacks                 []string
-	Workspace      string
+	Workspace                 string
-	MaxIterations  int
+	MaxIterations             int
-	MaxTokens      int
+	MaxTokens                 int
-	Temperature    float64
+	Temperature               float64
-	ContextWindow  int
+	ContextWindow             int
-	Provider       providers.LLMProvider
+	SummarizeMessageThreshold int
-	Sessions       *session.SessionManager
+	SummarizeTokenPercent     int
-	ContextBuilder *ContextBuilder
+	Provider                  providers.LLMProvider
-	Tools          *tools.ToolRegistry
+	Sessions                  *session.SessionManager
-	Subagents      *config.SubagentsConfig
+	ContextBuilder            *ContextBuilder
-	SkillsFilter   []string
+	Tools                     *tools.ToolRegistry
-	Candidates     []providers.FallbackCandidate
+	Subagents                 *config.SubagentsConfig
+	SkillsFilter              []string
+	Candidates                []providers.FallbackCandidate
 }
 
 // NewAgentInstance creates an agent instance from config.
@@ -101,6 +103,16 @@ func NewAgentInstance(
 		temperature = *defaults.Temperature
 	}
 
+	summarizeMessageThreshold := defaults.SummarizeMessageThreshold
+	if summarizeMessageThreshold == 0 {
+		summarizeMessageThreshold = 20
+	}
+
+	summarizeTokenPercent := defaults.SummarizeTokenPercent
+	if summarizeTokenPercent == 0 {
+		summarizeTokenPercent = 75
+	}
+
 	// Resolve fallback candidates
 	modelCfg := providers.ModelConfig{
 		Primary:   model,
@@ -149,22 +161,24 @@ func NewAgentInstance(
 	candidates := providers.ResolveCandidatesWithLookup(modelCfg, defaults.Provider, resolveFromModelList)
 
 	return &AgentInstance{
-		ID:             agentID,
+		ID:                        agentID,
-		Name:           agentName,
+		Name:                      agentName,
-		Model:          model,
+		Model:                     model,
-		Fallbacks:      fallbacks,
+		Fallbacks:                 fallbacks,
-		Workspace:      workspace,
+		Workspace:                 workspace,
-		MaxIterations:  maxIter,
+		MaxIterations:             maxIter,
-		MaxTokens:      maxTokens,
+		MaxTokens:                 maxTokens,
-		Temperature:    temperature,
+		Temperature:               temperature,
-		ContextWindow:  maxTokens,
+		ContextWindow:             maxTokens,
-		Provider:       provider,
+		SummarizeMessageThreshold: summarizeMessageThreshold,
-		Sessions:       sessionsManager,
+		SummarizeTokenPercent:     summarizeTokenPercent,
-		ContextBuilder: contextBuilder,
+		Provider:                  provider,
-		Tools:          toolsRegistry,
+		Sessions:                  sessionsManager,
-		Subagents:      subagents,
+		ContextBuilder:            contextBuilder,
-		SkillsFilter:   skillsFilter,
+		Tools:                     toolsRegistry,
-		Candidates:     candidates,
+		Subagents:                 subagents,
+		SkillsFilter:              skillsFilter,
+		Candidates:                candidates,
 	}
 }
 

pkg/agent/loop.go

@@ -1081,9 +1081,9 @@ func (al *AgentLoop) updateToolContexts(agent *AgentInstance, channel, chatID st
 func (al *AgentLoop) maybeSummarize(agent *AgentInstance, sessionKey, channel, chatID string) {
 	newHistory := agent.Sessions.GetHistory(sessionKey)
 	tokenEstimate := al.estimateTokens(newHistory)
-	threshold := agent.ContextWindow * 75 / 100
+	threshold := agent.ContextWindow * agent.SummarizeTokenPercent / 100
 
-	if len(newHistory) > 20 || tokenEstimate > threshold {
+	if len(newHistory) > agent.SummarizeMessageThreshold || tokenEstimate > threshold {
 		summarizeKey := agent.ID + ":" + sessionKey
 		if _, loading := al.summarizing.LoadOrStore(summarizeKey, true); !loading {
 			go func() {

pkg/config/config.go

@@ -180,6 +180,8 @@ type AgentDefaults struct {
 	MaxTokens                 int      `json:"max_tokens"                      env:"PICOCLAW_AGENTS_DEFAULTS_MAX_TOKENS"`
 	Temperature               *float64 `json:"temperature,omitempty"           env:"PICOCLAW_AGENTS_DEFAULTS_TEMPERATURE"`
 	MaxToolIterations         int      `json:"max_tool_iterations"             env:"PICOCLAW_AGENTS_DEFAULTS_MAX_TOOL_ITERATIONS"`
+	SummarizeMessageThreshold int      `json:"summarize_message_threshold"     env:"PICOCLAW_AGENTS_DEFAULTS_SUMMARIZE_MESSAGE_THRESHOLD"`
+	SummarizeTokenPercent     int      `json:"summarize_token_percent"         env:"PICOCLAW_AGENTS_DEFAULTS_SUMMARIZE_TOKEN_PERCENT"`
 	MaxMediaSize              int      `json:"max_media_size,omitempty"        env:"PICOCLAW_AGENTS_DEFAULTS_MAX_MEDIA_SIZE"`
 }
 

pkg/config/config_test.go

@@ -435,6 +435,18 @@ func TestLoadConfig_WebToolsProxy(t *testing.T) {
 }
 
 // TestDefaultConfig_DMScope verifies the default dm_scope value
+// TestDefaultConfig_SummarizationThresholds verifies summarization defaults
+func TestDefaultConfig_SummarizationThresholds(t *testing.T) {
+	cfg := DefaultConfig()
+
+	if cfg.Agents.Defaults.SummarizeMessageThreshold != 20 {
+		t.Errorf("SummarizeMessageThreshold = %d, want 20", cfg.Agents.Defaults.SummarizeMessageThreshold)
+	}
+	if cfg.Agents.Defaults.SummarizeTokenPercent != 75 {
+		t.Errorf("SummarizeTokenPercent = %d, want 75", cfg.Agents.Defaults.SummarizeTokenPercent)
+	}
+}
+
 func TestDefaultConfig_DMScope(t *testing.T) {
 	cfg := DefaultConfig()
 

pkg/config/defaults.go

@@ -26,13 +26,15 @@ func DefaultConfig() *Config {
 	return &Config{
 		Agents: AgentsConfig{
 			Defaults: AgentDefaults{
-				Workspace:           workspacePath,
+				Workspace:                 workspacePath,
-				RestrictToWorkspace: true,
+				RestrictToWorkspace:       true,
-				Provider:            "",
+				Provider:                  "",
-				Model:               "",
+				Model:                     "",
-				MaxTokens:           32768,
+				MaxTokens:                 32768,
-				Temperature:         nil, // nil means use provider default
+				Temperature:               nil, // nil means use provider default
-				MaxToolIterations:   50,
+				MaxToolIterations:         50,
+				SummarizeMessageThreshold: 20,
+				SummarizeTokenPercent:     75,
 			},
 		},
 		Bindings: []AgentBinding{},