opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: handle codex CLI stderr noise without losing valid stdout

Browse source 
Codex writes diagnostic messages to stderr (e.g. rollout errors) which
cause non-zero exit codes even when valid JSONL output exists on stdout.
Parse stdout first before checking exit code to avoid false errors.
This commit is contained in:
Leandro Barbosa 2026-02-13 14:31:22 -03:00
parent 41e924ec68
commit e44c6d9d7d
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
pkg/providers/codex_cli_provider.go
View file

@ -50,10 +50,22 @@ func (p *CodexCliProvider) Chat(ctx context.Context, messages []Message, tools [
cmd := exec.CommandContext(ctx, p.command, args...) cmd := exec.CommandContext(ctx, p.command, args...)
cmd.Stdin = bytes.NewReader([]byte(prompt)) cmd.Stdin = bytes.NewReader([]byte(prompt))
var stderr bytes.Buffer var stdout, stderr bytes.Buffer
cmd.Stdout = &stdout
cmd.Stderr = &stderr cmd.Stderr = &stderr
stdout, err := cmd.Output() err := cmd.Run()
// Parse JSONL from stdout even if exit code is non-zero,
// because codex writes diagnostic noise to stderr (e.g. rollout errors)
// but still produces valid JSONL output.
if stdoutStr := stdout.String(); stdoutStr != "" {
resp, parseErr := p.parseJSONLEvents(stdoutStr)
if parseErr == nil && resp != nil && (resp.Content != "" || len(resp.ToolCalls) > 0) {
return resp, nil
}
}
if err != nil { if err != nil {
if ctx.Err() == context.Canceled { if ctx.Err() == context.Canceled {
return nil, ctx.Err() return nil, ctx.Err()
@ -64,7 +76,7 @@ func (p *CodexCliProvider) Chat(ctx context.Context, messages []Message, tools [
return nil, fmt.Errorf("codex cli error: %w", err) return nil, fmt.Errorf("codex cli error: %w", err)
} }
return p.parseJSONLEvents(string(stdout)) return p.parseJSONLEvents(stdout.String())
} }
// GetDefaultModel returns the default model identifier. // GetDefaultModel returns the default model identifier.