opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: update tests for WebSearchToolOptions API change

Browse source 
Upstream refactored NewWebSearchTool to accept WebSearchToolOptions
struct instead of positional args. Update config_test.go and
web_test.go to match the new API.
This commit is contained in:
Leandro Barbosa 2026-02-13 14:45:48 -03:00
parent dc42aa7b18
commit e61faea8ce
2 changed files with 13 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/config/config_test.go
View file

@ -136,11 +136,11 @@ func TestDefaultConfig_WebTools(t *testing.T) {
cfg := DefaultConfig() cfg := DefaultConfig()
// Verify web tools defaults // Verify web tools defaults
if cfg.Tools.Web.Search.MaxResults != 5 { if cfg.Tools.Web.Brave.MaxResults != 5 {
t.Error("Expected MaxResults 5, got ", cfg.Tools.Web.Search.MaxResults) t.Error("Expected Brave MaxResults 5, got ", cfg.Tools.Web.Brave.MaxResults)
} }
if cfg.Tools.Web.Search.APIKey != "" { if cfg.Tools.Web.Brave.APIKey != "" {
t.Error("Search API key should be empty by default") t.Error("Brave API key should be empty by default")
} }
} }

25
pkg/tools/web_test.go
View file

@ -173,30 +173,23 @@ func TestWebTool_WebFetch_Truncation(t *testing.T) {
} }
} }
// TestWebTool_WebSearch_NoApiKey verifies error handling when API key is missing // TestWebTool_WebSearch_NoApiKey verifies that no tool is created when API key is missing
func TestWebTool_WebSearch_NoApiKey(t *testing.T) { func TestWebTool_WebSearch_NoApiKey(t *testing.T) {
tool := NewWebSearchTool("", 5) tool := NewWebSearchTool(WebSearchToolOptions{BraveEnabled: true, BraveAPIKey: ""})
ctx := context.Background() if tool != nil {
args := map[string]interface{}{ t.Errorf("Expected nil tool when Brave API key is empty")
"query": "test",
} }
result := tool.Execute(ctx, args) // Also nil when nothing is enabled
tool = NewWebSearchTool(WebSearchToolOptions{})
// Should return error result if tool != nil {
if !result.IsError { t.Errorf("Expected nil tool when no provider is enabled")
t.Errorf("Expected error when API key is missing")
}
// Should mention missing API key
if !strings.Contains(result.ForLLM, "BRAVE_API_KEY") && !strings.Contains(result.ForUser, "BRAVE_API_KEY") {
t.Errorf("Expected API key error message, got ForLLM: %s", result.ForLLM)
} }
} }
// TestWebTool_WebSearch_MissingQuery verifies error handling for missing query // TestWebTool_WebSearch_MissingQuery verifies error handling for missing query
func TestWebTool_WebSearch_MissingQuery(t *testing.T) { func TestWebTool_WebSearch_MissingQuery(t *testing.T) {
tool := NewWebSearchTool("test-key", 5) tool := NewWebSearchTool(WebSearchToolOptions{BraveEnabled: true, BraveAPIKey: "test-key", BraveMaxResults: 5})
ctx := context.Background() ctx := context.Background()
args := map[string]interface{}{} args := map[string]interface{}{}