opencode/yao
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1175 from trheyi/main

Browse source 
Refactor test files to improve readability and consistency
This commit is contained in:
Max 2025-10-07 10:32:57 +08:00 • committed by GitHub
commit 19942f085a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
openapi/tests/user/config_validation_test.go
View file

@ -10,11 +10,11 @@ import (
func TestConfigValidationLogic(t *testing.T) { func TestConfigValidationLogic(t *testing.T) {
// Test cases for different configuration scenarios // Test cases for different configuration scenarios
testCases := []struct { testCases := []struct {
name string name string
clientID string clientID string
clientSecret string clientSecret string
shouldPass bool shouldPass bool
expectedError string expectedError string
}{ }{
{ {
name: "valid_direct_values", name: "valid_direct_values",
@ -58,13 +58,13 @@ func TestConfigValidationLogic(t *testing.T) {
// This is a conceptual test - in practice, we'd test the actual validation logic // This is a conceptual test - in practice, we'd test the actual validation logic
t.Logf("Testing scenario: %s", tc.name) t.Logf("Testing scenario: %s", tc.name)
t.Logf("ClientID: %s, ClientSecret: %s", tc.clientID, tc.clientSecret) t.Logf("ClientID: %s, ClientSecret: %s", tc.clientID, tc.clientSecret)
if tc.shouldPass { if tc.shouldPass {
t.Logf("Expected: Should pass validation") t.Logf("Expected: Should pass validation")
} else { } else {
t.Logf("Expected: Should fail with error: %s", tc.expectedError) t.Logf("Expected: Should fail with error: %s", tc.expectedError)
} }
// This test documents the expected behavior // This test documents the expected behavior
assert.True(t, true, "Validation logic should be tested through integration tests") assert.True(t, true, "Validation logic should be tested through integration tests")
}) })
@ -90,7 +90,7 @@ func TestEnvVarNameExtraction(t *testing.T) {
for _, tc := range testCases { for _, tc := range testCases {
t.Run(tc.input, func(t *testing.T) { t.Run(tc.input, func(t *testing.T) {
t.Logf("Input: %s, Expected: %s", tc.input, tc.expected) t.Logf("Input: %s, Expected: %s", tc.input, tc.expected)
// This test documents the expected behavior of extractEnvVarName // This test documents the expected behavior of extractEnvVarName
// In practice, we'd need to make the function public or test it through integration // In practice, we'd need to make the function public or test it through integration
assert.True(t, true, "Function behavior should be tested through integration tests") assert.True(t, true, "Function behavior should be tested through integration tests")

8
openapi/tests/user/env_var_extraction_test.go
View file

@ -10,7 +10,7 @@ import (
func TestExtractEnvVarName(t *testing.T) { func TestExtractEnvVarName(t *testing.T) {
// Import the user package to access the function // Import the user package to access the function
// Note: This test assumes the function is exported or we can test it indirectly // Note: This test assumes the function is exported or we can test it indirectly
testCases := []struct { testCases := []struct {
input string input string
expected string expected string
@ -28,7 +28,7 @@ func TestExtractEnvVarName(t *testing.T) {
// Since extractEnvVarName is not exported, we'll test the behavior indirectly // Since extractEnvVarName is not exported, we'll test the behavior indirectly
// by checking if the error message contains the correct variable name // by checking if the error message contains the correct variable name
t.Logf("Testing input: %s, expected: %s", tc.input, tc.expected) t.Logf("Testing input: %s, expected: %s", tc.input, tc.expected)
// This is a conceptual test - in practice, we'd need to make the function public // This is a conceptual test - in practice, we'd need to make the function public
// or test it through the public API // or test it through the public API
assert.True(t, true, "Function behavior should be tested through integration tests") assert.True(t, true, "Function behavior should be tested through integration tests")
@ -40,7 +40,7 @@ func TestExtractEnvVarName(t *testing.T) {
func TestEnvVarNameExtractionIntegration(t *testing.T) { func TestEnvVarNameExtractionIntegration(t *testing.T) {
// This test verifies that the error message correctly identifies the missing environment variable // This test verifies that the error message correctly identifies the missing environment variable
// by checking the actual error message format // by checking the actual error message format
// Test with a custom environment variable name // Test with a custom environment variable name
testCases := []struct { testCases := []struct {
name string name string
@ -53,7 +53,7 @@ func TestEnvVarNameExtractionIntegration(t *testing.T) {
expected: "SIGNIN_CLIENT_ID", expected: "SIGNIN_CLIENT_ID",
}, },
{ {
name: "CUSTOM_CLIENT_ID", name: "CUSTOM_CLIENT_ID",
envVar: "CUSTOM_CLIENT_ID", envVar: "CUSTOM_CLIENT_ID",
expected: "CUSTOM_CLIENT_ID", expected: "CUSTOM_CLIENT_ID",
}, },