opencode/yao
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1298 from trheyi/main

Browse source 
Refactor object registration in Context for improved lifecycle manage…
This commit is contained in:
Max 2025-11-13 14:58:38 +08:00 • committed by GitHub
commit 22fbc69ad2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
agent/context/jsapi.go
View file

@ -20,10 +20,8 @@ func (ctx *Context) NewObject(v8ctx *v8go.Context) (*v8go.Value, error) {
jsObject := v8go.NewObjectTemplate(v8ctx.Isolate()) jsObject := v8go.NewObjectTemplate(v8ctx.Isolate())
id := uuid.NewString()
ctx.objectRegister(id)
// Set the id and release function // Set the id and release function
id := ctx.objectRegister()
jsObject.Set("__id", id) jsObject.Set("__id", id)
jsObject.Set("__release", ctx.objectRelease(v8ctx.Isolate(), id)) jsObject.Set("__release", ctx.objectRelease(v8ctx.Isolate(), id))
@ -32,15 +30,19 @@ func (ctx *Context) NewObject(v8ctx *v8go.Context) (*v8go.Value, error) {
jsObject.Set("Sid", ctx.Sid) jsObject.Set("Sid", ctx.Sid)
instance, err := jsObject.NewInstance(v8ctx) instance, err := jsObject.NewInstance(v8ctx)
if err != nil { if err != nil {
ctx.objectRelease(v8ctx.Isolate(), id)
return nil, err return nil, err
} }
return instance.Value, nil return instance.Value, nil
} }
func (ctx *Context) objectRegister(id string) { func (ctx *Context) objectRegister() string {
id := uuid.NewString()
objectsMutex.Lock() objectsMutex.Lock()
defer objectsMutex.Unlock() defer objectsMutex.Unlock()
objects[id] = ctx objects[id] = ctx
return id
} }
func (ctx *Context) objectRelease(iso *v8go.Isolate, id string) *v8go.FunctionTemplate { func (ctx *Context) objectRelease(iso *v8go.Isolate, id string) *v8go.FunctionTemplate {