opencode/yao
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enhance Script Runner Error Handling and Fail-Fast Logic

Browse source 
- Updated the ScriptRunner to treat both StatusFailed and StatusError as failures, improving failure reporting in test results.
- Modified the fail-fast logic to stop execution on both failure statuses, ensuring quicker feedback during test runs.
- Enhanced error handling in executeTestFunction to recover from panics and provide clearer error messages for JavaScript exceptions, improving test reliability and debugging.
This commit is contained in:
Max 2025-12-22 18:41:13 +08:00
parent 6ce6b65567
commit 4c80c3ffa0
1 changed files with 28 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
agent/test/script.go
View file

@ -246,14 +246,15 @@ func (r *ScriptRunner) Run() (*ScriptTestReport, error) {
switch result.Status { switch result.Status {
case StatusPassed: case StatusPassed:
report.Summary.Passed++ report.Summary.Passed++
case StatusFailed: case StatusFailed, StatusError:
// Both Failed and Error count as failures
report.Summary.Failed++ report.Summary.Failed++
case StatusSkipped: case StatusSkipped:
report.Summary.Skipped++ report.Summary.Skipped++
} }
// Check fail-fast // Check fail-fast (stop on both Failed and Error)
if r.opts.FailFast && result.Status == StatusFailed { if r.opts.FailFast && (result.Status == StatusFailed || result.Status == StatusError) {
r.output.Warning("Stopping due to --fail-fast") r.output.Warning("Stopping due to --fail-fast")
break break
} }
@ -397,7 +398,15 @@ func generateTestScriptID(filePath string, srcDir string) string {
} }
// executeTestFunction executes a single test function using V8 // executeTestFunction executes a single test function using V8
func (r *ScriptRunner) executeTestFunction(tc *ScriptTestCase, scriptInfo *ScriptInfo, testingT *TestingT, agentCtx *context.Context) error { func (r *ScriptRunner) executeTestFunction(tc *ScriptTestCase, scriptInfo *ScriptInfo, testingT *TestingT, agentCtx *context.Context) (execErr error) {
// Recover from panics thrown by Process calls
// Even if JavaScript try-catch catches the error, we want to fail the test
defer func() {
if r := recover(); r != nil {
execErr = fmt.Errorf("panic in test function: %v", r)
}
}()
// Get the test script (already loaded by loadAllScripts) // Get the test script (already loaded by loadAllScripts)
testScriptID := generateTestScriptID(scriptInfo.TestPath, filepath.Dir(scriptInfo.TestPath)) testScriptID := generateTestScriptID(scriptInfo.TestPath, filepath.Dir(scriptInfo.TestPath))
script, ok := v8.Scripts[testScriptID] script, ok := v8.Scripts[testScriptID]
@ -444,7 +453,7 @@ func (r *ScriptRunner) executeTestFunction(tc *ScriptTestCase, scriptInfo *Scrip
} }
// Call the test function with (t, ctx) // Call the test function with (t, ctx)
_, err = fn.Call(global, testingTObj, agentCtxObj) result, err := fn.Call(global, testingTObj, agentCtxObj)
if err != nil { if err != nil {
// Check if this is an assertion failure or a real error // Check if this is an assertion failure or a real error
if testingT.Failed() { if testingT.Failed() {
@ -454,6 +463,20 @@ func (r *ScriptRunner) executeTestFunction(tc *ScriptTestCase, scriptInfo *Scrip
return fmt.Errorf("test function error: %w", err) return fmt.Errorf("test function error: %w", err)
} }
// Check if the result is a JavaScript Error (thrown by bridge.JsException)
if result != nil && result.IsNativeError() {
// Get error message from Error object
if result.IsObject() {
obj, err := result.AsObject()
if err == nil {
if msgVal, err := obj.Get("message"); err == nil && !msgVal.IsUndefined() {
return fmt.Errorf("test threw exception: %s", msgVal.String())
}
}
}
return fmt.Errorf("test threw exception: %s", result.String())
}
return nil return nil
} }