opencode/yao
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor trace package tests for improved readability

Browse source 
- Removed unnecessary blank lines in multiple test files to enhance code clarity and maintainability.
- Adjusted formatting in `subscription.go`, `trace_bench_test.go`, `trace_concurrent_test.go`, `trace_mem_test.go`, `trace_node_test.go`, `trace_space_test.go`, and `trace_subscription_test.go` for consistency.
This commit is contained in:
Max 2025-11-18 15:48:21 +08:00
parent 3a46d98663
commit a7210f027f
7 changed files with 13 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
trace/subscription.go
View file

@ -37,7 +37,7 @@ func (m *manager) broadcast(update *types.TraceUpdate) {
// Channel was closed, ignore (subscriber cleanup race condition) // Channel was closed, ignore (subscriber cleanup race condition)
} }
}() }()
select { select {
case ch <- update: case ch <- update:
// Sent successfully // Sent successfully

1
trace/trace_bench_test.go
View file

@ -491,4 +491,3 @@ func getTraceScenarios() []traceScenario {
}, },
} }
} }

3
trace/trace_concurrent_test.go
View file

@ -80,7 +80,7 @@ func TestConcurrentSpaceOperations(t *testing.T) {
// Concurrent writes to the SAME space (now thread-safe with per-space locks) // Concurrent writes to the SAME space (now thread-safe with per-space locks)
var wg sync.WaitGroup var wg sync.WaitGroup
numWorkers := 10 numWorkers := 10
for i := 0; i < numWorkers; i++ { for i := 0; i < numWorkers; i++ {
wg.Add(1) wg.Add(1)
go func(idx int) { go func(idx int) {
@ -282,4 +282,3 @@ func TestConcurrentLogging(t *testing.T) {
}) })
} }
} }

1
trace/trace_mem_test.go
View file

@ -618,4 +618,3 @@ func TestGoroutineLeak(t *testing.T) {
t.Logf("✓ No goroutine leak detected") t.Logf("✓ No goroutine leak detected")
} }
} }

1
trace/trace_node_test.go
View file

@ -211,4 +211,3 @@ func TestCompleteWithOutput(t *testing.T) {
}) })
} }
} }

9
trace/trace_space_test.go
View file

@ -176,11 +176,10 @@ func TestSpaceGetSpace(t *testing.T) {
assert.Equal(t, "Test description", retrieved.Description) assert.Equal(t, "Test description", retrieved.Description)
assert.Equal(t, int64(7200), retrieved.TTL) assert.Equal(t, int64(7200), retrieved.TTL)
// Get non-existent space (returns nil, nil) // Get non-existent space (returns nil, nil)
nonExistent, err := manager.GetSpace("nonexistent") nonExistent, err := manager.GetSpace("nonexistent")
assert.NoError(t, err) assert.NoError(t, err)
assert.Nil(t, nonExistent) assert.Nil(t, nonExistent)
}) })
} }
} }

15
trace/trace_subscription_test.go
View file

@ -153,15 +153,15 @@ func TestSubscribeFrom(t *testing.T) {
// Channel closed // Channel closed
break collectLoop break collectLoop
} }
receivedUpdates = append(receivedUpdates, update) receivedUpdates = append(receivedUpdates, update)
// Check if we received step 2 events // Check if we received step 2 events
if update.Type == types.UpdateTypeNodeStart { if update.Type == types.UpdateTypeNodeStart {
if data, ok := update.Data.(*types.NodeStartData); ok { if data, ok := update.Data.(*types.NodeStartData); ok {
if data.Node != nil && data.Node.Label == "Finalizing" { if data.Node != nil && data.Node.Label == "Finalizing" {
foundStep2 = true foundStep2 = true
}
} }
} }
}
// Stop after receiving trace_complete // Stop after receiving trace_complete
if update.Type == types.UpdateTypeComplete { if update.Type == types.UpdateTypeComplete {
break collectLoop break collectLoop
@ -280,4 +280,3 @@ func TestMultipleSubscribers(t *testing.T) {
}) })
} }
} }