opencode/yao
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1192 from trheyi/main

Browse source 
Update UpdateUserLastLogin method to require loginCtx
This commit is contained in:
Max 2025-10-13 14:11:54 +08:00 • committed by GitHub
commit b3a365b53b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 20 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
openapi/oauth/providers/user/user_basic.go
View file

@ -468,12 +468,16 @@ func (u *DefaultUser) DeleteUser(ctx context.Context, userID string) error {
// UpdateUserLastLogin updates the user's last login timestamp and context // UpdateUserLastLogin updates the user's last login timestamp and context
func (u *DefaultUser) UpdateUserLastLogin(ctx context.Context, userID string, loginCtx *types.LoginContext) error { func (u *DefaultUser) UpdateUserLastLogin(ctx context.Context, userID string, loginCtx *types.LoginContext) error {
// Validate loginCtx is required
if loginCtx == nil {
return fmt.Errorf("loginCtx is required")
}
updateData := maps.MapStrAny{ updateData := maps.MapStrAny{
"last_login_at": time.Now(), "last_login_at": time.Now(),
} }
// Add login context fields if provided // Add login context fields
if loginCtx != nil {
if loginCtx.IP != "" { if loginCtx.IP != "" {
updateData["last_login_ip"] = loginCtx.IP updateData["last_login_ip"] = loginCtx.IP
} }
@ -486,7 +490,6 @@ func (u *DefaultUser) UpdateUserLastLogin(ctx context.Context, userID string, lo
if loginCtx.Platform != "" { if loginCtx.Platform != "" {
updateData["last_login_platform"] = loginCtx.Platform updateData["last_login_platform"] = loginCtx.Platform
} }
}
return u.UpdateUser(ctx, userID, updateData) return u.UpdateUser(ctx, userID, updateData)
} }

5
openapi/oauth/providers/user/user_basic_test.go
View file

@ -221,9 +221,10 @@ func TestUserBasicOperations(t *testing.T) {
assert.Equal(t, "desktop", user["last_login_device"]) assert.Equal(t, "desktop", user["last_login_device"])
assert.Equal(t, "web", user["last_login_platform"]) assert.Equal(t, "web", user["last_login_platform"])
// Test with nil loginCtx (should only update timestamp) // Test with nil loginCtx (should return error)
err = testProvider.UpdateUserLastLogin(ctx, testUserID, nil) err = testProvider.UpdateUserLastLogin(ctx, testUserID, nil)
assert.NoError(t, err) assert.Error(t, err)
assert.Contains(t, err.Error(), "loginCtx is required")
// Test with partial loginCtx (only IP) // Test with partial loginCtx (only IP)
partialCtx := &types.LoginContext{ partialCtx := &types.LoginContext{