opencode/yao
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: Simplify sheet dimension retrieval in Excel processing

Browse source 
- Replaced the previous method of calculating sheet dimensions with a more efficient approach using the `Cols` method.
- Removed commented-out code related to dimension handling, streamlining the function for better readability and maintainability.
This commit is contained in:
Max 2025-05-15 13:02:13 +08:00
parent 1cce634d24
commit c357c72934
1 changed files with 9 additions and 68 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

71
excel/sheet.go
View file

@ -91,77 +91,18 @@ func (excel *Excel) GetSheetDimension(name string) (rows int, cols int, err erro
defer ri.Close()
for ri.Next() {
rows++
row, err := ri.Columns()
}
// Get column count
ci, err := excel.File.Cols(name)
if err != nil {
return 0, 0, err
}
if len(row) > cols {
cols = max(cols, len(row))
}
for ci.Next() {
cols++
}
return rows, cols, nil
// // Get dimension directly using excelize API
// dimension, err := excel.File.GetSheetDimension(name)
// if err != nil {
// return 0, 0, err
// }
// // If sheet is not set, use row and column count
// if dimension == "A1" {
// rows = 0
// cols = 0
// ri, err := excel.File.Rows(name)
// if err != nil {
// return 0, 0, err
// }
// defer ri.Close()
// for ri.Next() {
// rows++
// row, err := ri.Columns()
// if err != nil {
// return 0, 0, err
// }
// if len(row) > cols {
// cols = max(cols, len(row))
// }
// }
// return rows, cols, nil
// }
// // If sheet is empty
// if dimension == "" || dimension == "A1" {
// return 0, 0, nil
// }
// // For single cell case, add the range suffix
// if !strings.Contains(dimension, ":") {
// dimension = fmt.Sprintf("%s:%s", dimension, dimension)
// }
// // Split dimension into start and end coordinates
// parts := strings.Split(dimension, ":")
// if len(parts) != 2 {
// return 0, 0, fmt.Errorf("invalid dimension format: %s", dimension)
// }
// // Convert end coordinate to row and column numbers
// endCol, endRow, err := excelize.CellNameToCoordinates(parts[1])
// if err != nil {
// return 0, 0, err
// }
// // Convert start coordinate to row and column numbers
// startCol, startRow, err := excelize.CellNameToCoordinates(parts[0])
// if err != nil {
// return 0, 0, err
// }
// // Calculate actual dimensions
// rows = endRow - startRow + 1
// cols = endCol - startCol + 1
// return rows, cols, nil
}
// ReadSheetRows reads all data from a sheet by rows