opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix linting checks

Browse source
This commit is contained in:
Kunal Karmakar 2026-03-14 07:01:05 +00:00
parent e0defab9a7
commit 03ed172623
2 changed files with 39 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
pkg/providers/common/common_test.go
View file

@ -262,8 +262,12 @@ func TestHandleErrorResponse_JSONError(t *testing.T) {
})) }))
defer server.Close() defer server.Close()
resp, _ := http.Get(server.URL) resp, err := http.Get(server.URL)
err := HandleErrorResponse(resp, server.URL) if err != nil {
t.Fatalf("http.Get() error = %v", err)
}
defer resp.Body.Close()
err = HandleErrorResponse(resp, server.URL)
if err == nil { if err == nil {
t.Fatal("expected error") t.Fatal("expected error")
} }
@ -283,8 +287,12 @@ func TestHandleErrorResponse_HTMLError(t *testing.T) {
})) }))
defer server.Close() defer server.Close()
resp, _ := http.Get(server.URL) resp, err := http.Get(server.URL)
err := HandleErrorResponse(resp, server.URL) if err != nil {
t.Fatalf("http.Get() error = %v", err)
}
defer resp.Body.Close()
err = HandleErrorResponse(resp, server.URL)
if err == nil { if err == nil {
t.Fatal("expected error") t.Fatal("expected error")
} }
@ -302,7 +310,11 @@ func TestReadAndParseResponse_ValidJSON(t *testing.T) {
})) }))
defer server.Close() defer server.Close()
resp, _ := http.Get(server.URL) resp, err := http.Get(server.URL)
if err != nil {
t.Fatalf("http.Get() error = %v", err)
}
defer resp.Body.Close()
out, err := ReadAndParseResponse(resp, server.URL) out, err := ReadAndParseResponse(resp, server.URL)
if err != nil { if err != nil {
t.Fatalf("ReadAndParseResponse() error = %v", err) t.Fatalf("ReadAndParseResponse() error = %v", err)
@ -319,8 +331,12 @@ func TestReadAndParseResponse_HTMLResponse(t *testing.T) {
})) }))
defer server.Close() defer server.Close()
resp, _ := http.Get(server.URL) resp, err := http.Get(server.URL)
_, err := ReadAndParseResponse(resp, server.URL) if err != nil {
t.Fatalf("http.Get() error = %v", err)
}
defer resp.Body.Close()
_, err = ReadAndParseResponse(resp, server.URL)
if err == nil { if err == nil {
t.Fatal("expected error for HTML response") t.Fatal("expected error for HTML response")
} }
@ -484,8 +500,12 @@ func TestHandleErrorResponse_EmptyBody(t *testing.T) {
})) }))
defer server.Close() defer server.Close()
resp, _ := http.Get(server.URL) resp, err := http.Get(server.URL)
err := HandleErrorResponse(resp, server.URL) if err != nil {
t.Fatalf("http.Get() error = %v", err)
}
defer resp.Body.Close()
err = HandleErrorResponse(resp, server.URL)
if err == nil { if err == nil {
t.Fatal("expected error") t.Fatal("expected error")
} }
@ -503,8 +523,12 @@ func TestReadAndParseResponse_InvalidJSON(t *testing.T) {
})) }))
defer server.Close() defer server.Close()
resp, _ := http.Get(server.URL) resp, err := http.Get(server.URL)
_, err := ReadAndParseResponse(resp, server.URL) if err != nil {
t.Fatalf("http.Get() error = %v", err)
}
defer resp.Body.Close()
_, err = ReadAndParseResponse(resp, server.URL)
if err == nil { if err == nil {
t.Fatal("expected error for invalid JSON") t.Fatal("expected error for invalid JSON")
} }

6
pkg/providers/factory_provider.go
View file

@ -10,8 +10,8 @@ import (
"strings" "strings"
"github.com/sipeed/picoclaw/pkg/config" "github.com/sipeed/picoclaw/pkg/config"
"github.com/sipeed/picoclaw/pkg/providers/azure"
anthropicmessages "github.com/sipeed/picoclaw/pkg/providers/anthropic_messages" anthropicmessages "github.com/sipeed/picoclaw/pkg/providers/anthropic_messages"
"github.com/sipeed/picoclaw/pkg/providers/azure"
) )
// createClaudeAuthProvider creates a Claude provider using OAuth credentials from auth store. // createClaudeAuthProvider creates a Claude provider using OAuth credentials from auth store.
@ -102,7 +102,9 @@ func CreateProviderFromConfig(cfg *config.ModelConfig) (LLMProvider, string, err
return nil, "", fmt.Errorf("api_key is required for azure protocol") return nil, "", fmt.Errorf("api_key is required for azure protocol")
} }
if cfg.APIBase == "" { if cfg.APIBase == "" {
return nil, "", fmt.Errorf("api_base is required for azure protocol (e.g., https://your-resource.openai.azure.com)") return nil, "", fmt.Errorf(
"api_base is required for azure protocol (e.g., https://your-resource.openai.azure.com)",
)
} }
return azure.NewProviderWithTimeout( return azure.NewProviderWithTimeout(
cfg.APIKey, cfg.APIKey,