opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove premature defer client.Stop() in GitHub Copilot provider

Browse source
This commit is contained in:
Yasuhiro Matsumoto 2026-02-16 00:13:20 +09:00
parent 214b201bfa
commit 3101c33cc7
No known key found for this signature in database
GPG key ID: F2EA90DF2C146D1E
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/providers/github_copilot_provider.go
View file

@ -33,11 +33,15 @@ func NewGitHubCopilotProvider(uri string, connectMode string, model string) (*Gi
if err := client.Start(context.Background()); err != nil { if err := client.Start(context.Background()); err != nil {
return nil, fmt.Errorf("Can't connect to Github Copilot, https://github.com/github/copilot-sdk/blob/main/docs/getting-started.md#connecting-to-an-external-cli-server for details") return nil, fmt.Errorf("Can't connect to Github Copilot, https://github.com/github/copilot-sdk/blob/main/docs/getting-started.md#connecting-to-an-external-cli-server for details")
} }
defer client.Stop() var err error
session, _ = client.CreateSession(context.Background(), &copilot.SessionConfig{ session, err = client.CreateSession(context.Background(), &copilot.SessionConfig{
Model: model, Model: model,
Hooks: &copilot.SessionHooks{}, Hooks: &copilot.SessionHooks{},
}) })
if err != nil {
client.Stop()
return nil, fmt.Errorf("failed to create Copilot session: %w", err)
}
} }