opencode/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(docs): simplify magic constants section in DDR session summarization design

Browse source 
Signed-off-by: Boris Bliznioukov <blib@mail.com>
This commit is contained in:
Boris Bliznioukov 2026-03-06 16:13:04 +01:00
parent d322db75c3
commit b44b0a0b57
No known key found for this signature in database
1 changed files with 1 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
docs/design/DDR-session-summarization.md
View file

@ -39,20 +39,7 @@ Session context grows without bound during long conversations. The original impl
- `WithLLMSummarizer(provider, model, agentID string, cfg config.SummarizationConfig) Option` — convenience, constructs `LLMSummarizer` internally.
- When `summarizer` is nil, `MaybeSummarize` is a no-op.
4. **MUST** replace all magic constants with named defaults in `pkg/config`:
| Constant | Value | Field |
|---|---|---|
| `DefaultSummarizeMessageThreshold` | `20` | `MessageThreshold` |
| `DefaultSummarizeTokenPercent` | `75` | `TokenPercent` |
| `DefaultKeepLastMessages` | `4` | `KeepLastMessages` |
| `DefaultContextWindow` | `8192` | `ContextWindow` |
| `DefaultSummaryMaxTokens` | `1024` | `SummaryMaxTokens` |
| `DefaultSummarizationTemperature` | `0.3` | `SummaryTemperature` |
| `DefaultMultiPartBatchThreshold` | `10` | `MultiPartBatchThreshold` |
| `DefaultSummarizationTimeout` | `120s` | `Timeout` |
| `DefaultMaxSingleMsgTokenRatio` | `0.5` | `MaxSingleMsgTokenRatio` |
| `DefaultForceCompressionMinMsgs` | `4` | `ForceCompressionMinMessages` |
| `DefaultCharsPerToken` | `2.5` | `CharsPerToken` |
4. **MUST** replace all magic constants with named defaults in `pkg/config`
5. **MUST** use a single `SummarizationConfig` struct in `pkg/config` as the sole config type for both user-facing JSON fields and internal tuning parameters: